added columns_view field in get table rows response object#1495
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds the columns_view field to the nested table_settings object in the get table rows response. The majority of the changes are formatting updates converting spaces to tabs across multiple files.
Changes:
- Added
columns_viewfield to thetable_settingsnested object in the response returned byGetTableRowsUseCase - Converted indentation from spaces to tabs across three files for consistency
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| backend/src/entities/table/use-cases/get-table-rows.use.case.ts | Added columns_view to table_settings response object (line 261); converted spacing to tabs |
| backend/src/entities/table-settings/personal-table-settings/personal-table-settings.controller.ts | Formatting only - converted spaces to tabs |
| backend/src/entities/table-settings/personal-table-settings/dto/create-personal-table-settings.dto.ts | Formatting only - converted spaces to tabs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| can_delete: can_delete, | ||
| can_update: can_update, | ||
| can_add: can_add, | ||
| columns_view: personalTableSettings?.columns_view ? personalTableSettings.columns_view : [], |
There was a problem hiding this comment.
The columns_view field is being added to the table_settings object, but the TableSettingsInRowsDS class definition (in found-table-rows.ds.ts) does not include this field. This will cause a type mismatch and the field won't be properly documented in the API schema. You need to add the columns_view field to the TableSettingsInRowsDS class with the appropriate @ApiProperty decorator.
| columns_view: personalTableSettings?.columns_view ? personalTableSettings.columns_view : [], |
| can_delete: can_delete, | ||
| can_update: can_update, | ||
| can_add: can_add, | ||
| columns_view: personalTableSettings?.columns_view ? personalTableSettings.columns_view : [], |
There was a problem hiding this comment.
Inconsistent default value for columns_view. At the root level (line 234), columns_view defaults to 'undefined' when not present, but in table_settings it defaults to an empty array '[]'. This inconsistency could confuse API consumers. Consider using the same default value in both places for consistency.
No description provided.